JSON to Dictionary: how to add new associations?

jamshark70 · March 5, 2023, 2:32pm

parseJSON may produce a corrupt Dictionary object

opened 12:49AM - 05 Mar 23 UTC

bug comp: sclang

## Environment * SuperCollider version: dev as of 3/5/23 * Operating system:… any * Other details (Qt version, audio driver, etc.): n/a ## Steps to reproduce If the class library produces a Dictionary by its own methods: ```supercollider d = Dictionary["test1" -> 123]; d.dump; Instance of Dictionary { (0x558ca57ae848, gc=C4, fmt=00, flg=00, set=02) instance variables [2] array : instance of Array (0x558ca57aed18, size=4, set=2) size : Integer 1 } ``` Notice that the dictionary size = 1, and the array size = 4. This is stipulated in Dictionary:put -- `if (array.size < (size * 4), { this.grow });` -- this line means, the array size should never be smaller than 4x the number of Dictionary items. But: ``` d = "{ \"test1\": 123 }".parseJSON; d.dump; Instance of Dictionary { (0x558ca5971118, gc=C0, fmt=00, flg=00, set=02) instance variables [2] array : instance of Array (0x558ca5970e58, size=2, set=2) size : Integer 1 } ``` size == 1 as expected, but the array size is 2, violating the rule. The consequence: ``` d.put("test2", 456); ERROR: Primitive '_BasicPut' failed. Index out of range. RECEIVER: Instance of Array { (0x558ca5970e58, gc=C0, fmt=01, flg=00, set=02) indexed slots [2] 0 : "test1" 1 : "123" } CALL STACK: ... snip... Dictionary:put arg this = <instance of Dictionary> arg key = "test2" arg value = 456 var atKey = nil var index = -2 ``` `scanFor` has produced a wrong index for the new item, because of the wrong array size. The bug, then, is in the `_String_ParseYAML` primitive. #5946 may be related but I don't know this for sure.

Last post for at least a month, I’m out.

hjh