Changes to email style on July 9

[alln4tural]

Hi Webmasters!

On July 9th, something changed in the way emails are styled that made quotes and code blocks illegible in my email reader.

Up to and including this post:

Mono source DX-7

There’s one caveat I couldn’t improve from the original source. The main function defines a new ParGroup as a local var… so hitting Cmd. will cause this to occur: FAILURE IN SERVER /n_free Node 1009 not found FAILURE IN SERVER /n_set Node 1004 not found FAILURE IN SERVER /s_new Group 1003 not found I tried one solution: changing the local var to global appending the source with CmdPeriod.add{ ~dx7group = new ( ParGroup ) } Of course, the synthdefs are compiled & defined with the origi…

quotes and code blocks look fine, rendered in sort of light grey on dark grey

Starting with this one

Galton board sim

You can use Pen.addRect to draw rectangles. From the help file: ( w = Window.new.front; w.view.background_(Color.white); w.drawFunc = { 80.do{ // set the Color Pen.color = Color.green(rrand(0.0, 1), rrand(0.0, 0.5)); Pen.addRect( Rect(20, 20, (w.bounds.width-40).rand, (w.bounds.height-40).rand) ); Pen.perform([\stroke, \fill].choose); } }; w.refresh; ) Best, Paul

and in all following messages, the code blocks appear white on white.

Would it be possible to revert whatever change was made in the three or so hours between those two posts?

Thanks!
eddi

[scztt]

No change was made intentionally, but probably this was caused by a Discourse server update? Can you send the html source of the “before” email and the “after” email?

FWIW my emails look fine before and after, but I notice that I have a white background in my email client, and you have a dark background - my guess is that somehow the background color of the code blocks is being explicitly set to white now, which may conflict with dark mode on email clients? Is the code present but white?

[alln4tural]

Thanks for looking into this, Scott!

Your guesses sound plausible to me; yes, the code is present, just rendered in the (more or less) same color as the background, so invisible. If you’re right about the hard coding of the bg color, i guess it would be a sort of thinko/bug to not also hardcode the font color … though from my pov, they could have just ain’t broke, don’t fix it, it looked fine before.

Where can I send the html sources?

Thanks!

[scztt]

Just paste them here (inside ``` backticks) or post as an attachment. I’m hoping I can track the change back to something in the Discourse source code from the html and file a bug on it…

[scztt]

Nevermind, no need to send! I don’t know why this would have broken, but this change for sure fixes it. We’re on beta 6, and this is in beta 7 so it should be resolved when we can upgrade (very soon).

FEATURE: Enables support for dark mode emails (#16520)

Thanks for reporting this, glad we could get it resolved quickly.

[scztt]

I upgraded the Discourse version, let me know if it resolves the email problem.

Here's a test! This should be visible in your email client now.

[alln4tural]

Unfortunately not : (

Thanks for trying

[scztt]

Okay, lol, if you can post the before and after HTML after all, I’ll pass the bug along to Discourse.

[alln4tural]

Changes to email style on July 9

Okay, lol, if you can post the before and after HTML after all, I’ll pass the bug along to Discourse.

hi Scott,

i’m embarrassed to discover i can’t figure out how to get at the html from within the email client on my phone. Could you DM me your email address so i can forward the before and after messages?

thanks!
eddi