Many PRs with "Review required: At least 1 approving review is required by reviewers with write access."

Development
1

Hello!

I think there are too many PRs with the following status:
Review required
At least 1 approving review is required by reviewers with write access.

I do not have write access and do not know C++ and the details of the development process. However, many of them seem to be OK and seem to be good features… I think it’s not so good that approval is stagnating too long!

2 Likes
2

If you’d like you can familiarize yourself with the development and review process here:

The contributing directory also has related info on filing Issues and creating PRs (which reviewers should be familiar with).

2 Likes
3

Thanks for the links!

I am not sure if I am fit to be a reviewer. It is not a matter of will but of ability. If I am confident, I will try to join as a reviewer.

1 Like
4

It’s useful in any case if you submit PRs to know some of the guidelines for those reviewing (and to understand why it can take some time). And of course the conversation thread is open to anyone to give feedback, if not officially a review.

2 Likes
5

Agree there is a real need for more reviewers particularly on the cpp side!

2 Likes
6

Please feel free to ping me for cpp reviews - I’ll try to set up “code owners” and some groups on github so it happens automatically and people can register as reviewers for particular parts of the codebase

2 Likes