performBinaryOpOnUGen is not returned by UGen

elgiano · June 9, 2020, 9:18am

supercollider/supercollider/blob/0e8b7153be8f8c64e35ef3d914a8191a09997b94/SCClassLibrary/Common/Audio/UGen.sc#L422




	// PRIVATE
	// function composition
	composeUnaryOp { arg aSelector;
		^UnaryOpUGen.new(aSelector, this)
	}
	composeBinaryOp { arg aSelector, anInput;
		if (anInput.isValidUGenInput, {
			^BinaryOpUGen.new(aSelector, this, anInput)
		},{
			anInput.performBinaryOpOnUGen(aSelector, this);
		});
	}
	reverseComposeBinaryOp { arg aSelector, aUGen;
		^BinaryOpUGen.new(aSelector, aUGen, this)
	}
	composeNAryOp { arg aSelector, anArgList;
		^thisMethod.notYetImplemented
	}


	// complex support

Anyone knows why the first branch returns and the second doesn’t? It would makes sense to me that when an InvalidUGenInput is asked to .performBinaryOpOnUGen, it would return a valid ugen input (and in fact all present implementations do)

(I looked through the history and this has been like that since ‘Initial Commit’)

jamshark70 · June 9, 2020, 12:29pm

Bug. Fix it

hjh

elgiano · June 9, 2020, 12:31pm

Thanks @jamshark70! Sending a PR